Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AAE-18459] Fix invalidateSession is called when auth is not initilized by js-api #9152

Merged
merged 2 commits into from
Dec 14, 2023
Merged

[AAE-18459] Fix invalidateSession is called when auth is not initilized by js-api #9152

merged 2 commits into from
Dec 14, 2023

Conversation

alep85
Copy link
Contributor

@alep85 alep85 commented Dec 11, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/AAE-18459

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@alep85 alep85 force-pushed the dev-alepore-AAE-18459 branch from 5a16692 to b03a4e3 Compare December 11, 2023 11:37
@alep85 alep85 changed the title [AAE-18459] Fix [AAE-18459] Fix invalidateSession is called when auth is not initilized by js-api Dec 11, 2023
@alep85 alep85 marked this pull request as ready for review December 11, 2023 18:30
@alep85 alep85 force-pushed the dev-alepore-AAE-18459 branch from b46e0f2 to 50ac426 Compare December 11, 2023 18:31
@alep85 alep85 force-pushed the dev-alepore-AAE-18459 branch from eea185a to 5f5c0e4 Compare December 12, 2023 15:08
@alep85 alep85 force-pushed the dev-alepore-AAE-18459 branch from 48f9818 to 60bd291 Compare December 14, 2023 09:26
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mauriziovitale
Copy link
Contributor

Merged as agreed with reviewers

@mauriziovitale mauriziovitale merged commit 0932a3e into develop Dec 14, 2023
30 of 33 checks passed
@mauriziovitale mauriziovitale deleted the dev-alepore-AAE-18459 branch December 14, 2023 18:51
Yasa-Nataliya pushed a commit that referenced this pull request Dec 15, 2023
@alep85 @Yasa-Nataliya
[AAE-18459] Fix invalidateSession is called when auth is not initiliz…
e0e2d82 
…ed by js-api (#9152)

* [AAE-18459] Replace all placeholders if the configuration key is an object

* [AAE-18459] don't invalidate session if authentication is not handled by js-api
wojd0 pushed a commit that referenced this pull request Dec 19, 2023
@alep85 @wojd0
[AAE-18459] Fix invalidateSession is called when auth is not initiliz…
e01f1ea 
…ed by js-api (#9152)

* [AAE-18459] Replace all placeholders if the configuration key is an object

* [AAE-18459] don't invalidate session if authentication is not handled by js-api
wojd0 pushed a commit that referenced this pull request Dec 19, 2023
@alep85 @wojd0
[AAE-18459] Fix invalidateSession is called when auth is not initiliz…
281870e 
…ed by js-api (#9152)

* [AAE-18459] Replace all placeholders if the configuration key is an object

* [AAE-18459] don't invalidate session if authentication is not handled by js-api
@MichalKinas MichalKinas mentioned this pull request Feb 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eromano eromano eromano approved these changes

@DenysVuika DenysVuika DenysVuika approved these changes

@popovicsandras popovicsandras Awaiting requested review from popovicsandras popovicsandras is a code owner

@mauriziovitale mauriziovitale Awaiting requested review from mauriziovitale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alep85 @mauriziovitale @DenysVuika @eromano